Optimize compute dispatch and buffer upload - #246
Closed
tychedelia wants to merge 1 commit into
Closed
tychedelia wants to merge 1 commit into
tychedelia wants to merge 1 commit into
Conversation
Contributor
|
awesome! what is a good way to test this? |
Member
Author
great q, i think this is an example of where the tests passing are a good indication. this should mostly be a behind the scenes thing (in a few cases) or a new performance tool for power users. i'm going to open a pr that reworks some of the flocking stuff soon which may be a good place to dig deeper too. |
Member
Author
|
Reopened from the upstream branch so it can anchor a PR stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, every compute dispatch runs a full
app.update()to be maximally pessimistic about changes to GPU resources that may not have been flushed to the GPU yet. For many particle sims which chain dispatches together this is exceedingly wasteful. This adds a newcompute_dispatch_no_updatewhich simply does the dispatch if the user is sure that there have been no un-flushed writes in the meantime.Also changes how we do buffer uploads. Previously, we would block on a full readback to sync the buffer into CPU memory. Now, we just write directly into the GPU buffer. This is fine, because reads still incur the full sync but if the user only writes but never reads we can stay on the fast path and let the CPU side buffer get out of sync.