Skip to content

Update deploy.yaml trigger to be upon release publishing - #4267

Open
clairep94 wants to merge 7 commits into
developfrom
clairep/fix_deploy_to_production_trigger
Open

clairep94 wants to merge 7 commits into
developfrom
clairep/fix_deploy_to_production_trigger

Conversation

@clairep94

@clairep94 clairep94 commented Aug 24, 2026 •

Copy link
Copy Markdown
Collaborator

Issue:

Fixes #
Remake of #4252

  • update deploy workflow trigger to be upon publishing a release on Github UI (instead of merges into the release branch)

Demo:

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@clairep94 clairep94 changed the title fix: update deploy.yaml trigger to be upon release publish, instead o… Update deploy.yaml trigger to be upon release publishing Aug 24, 2026
@clairep94
clairep94 marked this pull request as ready for review August 24, 2026 00:20
@clairep94
clairep94 requested a review from doradocodes August 24, 2026 00:25
@clairep94

Copy link
Copy Markdown
Collaborator Author

Hold off on this one till #4281 is addressed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Deploy safety/traceability regressions are introduced by removing the previous branch/test gating and by not tagging images with the release version.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the production deployment GitHub Actions workflow to run when a GitHub Release is published, aligning deployments with the release-publishing flow instead of merges to a specific branch.

Changes:

  • Switched deploy.yml trigger from workflow_run (Test on release branch) to release event (published).
  • Updated checkout to build from the published release tag (github.event.release.tag_name).
File summaries
File Description
.github/workflows/deploy.yml Changes the deployment trigger to release.published and checks out the published release tag for the production build/deploy.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/deploy.yml
Comment thread .github/workflows/deploy.yml
@clairep94 clairep94 added the Do not merge This change is dependent on another change and should not be merged yet label Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A critical shell-injection vulnerability remains in release tag handling.

Review effort: Lite
Findings: 1 High severity

Open (1)
Resolved since last review (2)

Comment thread .github/workflows/deploy.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Passing release tags directly to Docker can block deployment for valid tags containing unsupported characters.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

Comment thread .github/workflows/deploy.yml
@clairep94 clairep94 removed the Do not merge This change is dependent on another change and should not be merged yet label Oct 3, 2026
…s with '+' as Docker tags'

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The deployment gates and tag checkout match the documented release process, with no unresolved findings.

Review effort: Balanced
Findings: None

Resolved since last review (1)

This branch is waiting to be deployed

1 waiting deployment
e2e-tests — 7877ed27 Waiting Oct 3, 2026 by clairep94 via test-e2e #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants