Sound examples - #1232
Draft
ogbabydiesal wants to merge 9 commits into
Draft
Conversation
Contributor
|
Hi @ogbabydiesal, I know this PR is still a draft. Before marking it ready to review, here are a few things to address: Please add a description to the PR, also link the related issue using "Resolves #issue number" in the description |
Member
|
Hi @Nwakaego-Ego thanks for the notes! @ogbabydiesal and I are working on this one together, there's a couple things left to do in addition to the points you mentioned |
This was referenced Jun 9, 2026
ksen0
reviewed
Jul 22, 2026
| export const p5Version = "2.3.0" as const; | ||
| export const p5SoundVersion = "0.2.0" as const; | ||
| export const p5Version = "2.2.2" as const; | ||
| export const p5SoundVersion = "0.3.0" as const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses processing/p5.sound.js#86