Skip to content

Gradle 9 compatibility#1535

Merged
catilac merged 1 commit into
processing:mainfrom
letorbi:gradle9-compatibility
Jun 30, 2026
Merged

Gradle 9 compatibility#1535
catilac merged 1 commit into
processing:mainfrom
letorbi:gradle9-compatibility

Conversation

@letorbi

@letorbi letorbi commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Currently the build process fails with Gradle 9 due to a depreciated statement in app/build.gradle.kt. The relevant part of the error message is:

Script compilation errors:

  Line 566:             exec {
                        ^ Unresolved reference 'exec'.

  Line 567:                 commandLine("codesign", "--timestamp", "--force", "--deep","--options=runtime", "--entitlements", entitlements, "--sign", "Developer ID Application", file)
                            ^ Unresolved reference 'commandLine'.

2 errors

This PR enables Gradle 9 compatibility by replacing the commandLine(...) statement with Runtime.getRuntime().exec(arrayOf(...)). After this, the build process runs smoothly on Linux.

Important: Even though I am pretty sure that the new statement will work, I was not able to test it on MacOS, which seems to be the only system that actually executes the modified line. This should be done by a reviewer before merging the PR.

@letorbi

letorbi commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@catilac I've read in PR #1523 that you are currently working on the build system, so this PR might be interesting for you.

@catilac

catilac commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

We are upgrading to gradle 9 in a different branch. Also I don't feel comfortable with a first-time contributor making changes to our build system. I recommend you read CONTRIBUTION.md. Thank you!

@catilac catilac closed this Jun 29, 2026
@letorbi

letorbi commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Ok, good to know that you are already on it.

I searched for Gradle relates issues and branches before creating the PR, but didn't find anything, therefore I assumed it was fine to create the PR - I am sorry, if not. I am also not exactly a first-time contributor: Ben merged a PR from me in 2021 (b1eed96) and I am the maintainer of the Processing packages for Arch Linux since a least six years.

Anyway, since I am also not exactly a regular contributor, I re-read the contribution guidelines, but I still do not really see an obvious mistake I made by creating the PR. Maybe the fact, that I was not able to test the change on a Mac or should I have created an issue before creating the PR? Could you please point me to the thing I am missing?

Last question: Is there an issue regarding the Gradle 9 migration I could subscribe to? The Arch packages I maintain contain my patch right now to avoid the heavy Gradle 8 dependency, but I'd like to remove it as soon as your branch has been merged into main.

@catilac

catilac commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

@letorbi No need to be sorry! I think it's helpful to open up an issue. The project is somewhat disorganized right now (my fault). Also I didn't realize you had contributed in the past. I think that's great.

I'm happy you're here. We have been discussing gradle 9 in the discord, and it's also come up here: #1514

I wouldn't call that well documented. I'll create a proper issue, because we do want to upgrade and I need help figuring out what would break if we suddenly made that upgrade.

@catilac catilac reopened this Jun 30, 2026
@catilac catilac merged commit e40819e into processing:main Jun 30, 2026
6 checks passed
@catilac

catilac commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

@letorbi merged thank you

@letorbi

letorbi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@catilac Thank you for merging my PR. I've also subscribed to the issue you've mentioned and joined the Discord server. See you there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants