Repository navigation
App grants: one secret sealed to an external app (key hub phase 1) - #286
Merged
Merged
Conversation
…r inbox Phase 1 of the CoinPay <-> logicsrc key hub (spec: claude.ai/artifact/LAZgAiqWqeLQ14uJ5JpdKb). - /grant consent page: logicsrc fetches the request manifest from the app's own origin over TLS (/.well-known/logicsrc-grant/<nonce>), public hosts only, so the page shows a verified origin, not a claimed name - The browser decrypts with the identity key (as the vault page does) and seals with @profullstack/sealed-secrets to the app's inbox; the server stores ciphertext + metadata only (app_grant_requests, app_grants) - Signed Standard Webhooks to the app: grant.delivered / updated / revoked - Signing keys (wallet, seed, SSH) are refused for apps - rotate-keys re-seals the new value to every app grant on the old fingerprint (resealAppGrants); /apps lists and revokes grants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan55 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 29 | LOW: 24
…and 5 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of the CoinPay ↔ logicsrc key hub. Spec: https://claude.ai/artifact/LAZgAiqWqeLQ14uJ5JpdKb (private doc).
What
An app asks for named keys. You approve on logicsrc. Your browser decrypts each value and seals it to that app's per-user inbox key. logicsrc relays ciphertext only.
/grant?origin=&nonce=<origin>/.well-known/logicsrc-grant/<nonce>itself, over TLS, so the consent page shows a verified origin. Anything the app POSTs is never trusted.@profullstack/sealed-secrets, the format meshhook, smshub and others already open.app_grantsas metadata plus ciphertext only.grant.delivered,grant.updated,grant.revoked.teams rotate-keysnow re-seals the new value to every grant on the old fingerprint (resealAppGrants). Each grant reads its own vault and secret name, and the result is reported in the run output./appslists grants and revokes them. Revoking tells the app to delete its copy and says to rotate as well.Defaults taken for the spec's open questions
Tests
apps/pwa: 122/122. The newapp-grants.test.mjsruns a full crypto round trip against a fake app (manifest, consent, approve, signed webhook, the app's own key opens it). It also covers signing-key refusal, stale fingerprints, another user's request, rotation re-delivery and revoke.packages/cli: the newrotate-app-grants.test.tspasses, and so do the existing rotate tests.umbrella.test.tshas 2 failures that already fail on master (checked in a clean worktree).🤖 Generated with Claude Code