Repository navigation
fix(clock): karaoke lyrics follow again on AI label stations (0.80.4) - #430
Merged
Merged
Conversation
… karaoke lyrics follow again (0.80.4) The AI label stations play hard links under ~/Downloads/ai-radio, which no library source covers. durationOf only asked the library index, so /clock answered duration 0 and the /music player stopped before highlighting the synced lyrics (and hid the progress bar). durationOf now falls back to a cached background ffprobe; the player re-asks the clock every 2 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan12 finding(s) in the 4 file(s) this pull request changes. HIGH: 11 | MEDIUM: 1
44 pre-existing finding(s) elsewhere in the repository — **HIGH**: 6 | **MEDIUM**: 14 | **LOW**: 24Not introduced by this pull request.
…and 24 more; the full set is in the SARIF artifact. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /music lyrics panel stopped lighting lines:
/clockansweredduration: 0for every AI label station on server2, andtick()in web/src/music.ts returns beforehighlight()when the duration is 0.Cause: the AI label stations play hard links under
~/Downloads/ai-radio, which no library source covers (sources are~/Downloads/doneand~/Downloads/Downloads/done).durationOfonly asked the library index.Fix:
durationOffalls back toDurationProbe(track-facts.ts), a cached background ffprobe keyed by size+mtime. The first clock answer may still be 0; the player asks again every 2 s and gets the length then.Tests: new track-facts test (stub ffprobe), station tests 25/25, tsc clean, pack:cli OK.
🤖 Generated with Claude Code