Skip to content

fix(clock): karaoke lyrics follow again on AI label stations (0.80.4) - #430

Merged
ralyodio merged 1 commit into
mainfrom
fix/clock-duration-fallback
Nov 14, 2026
Merged

ralyodio merged 1 commit into
mainfrom
fix/clock-duration-fallback

Conversation

@ralyodio

Copy link
Copy Markdown
Contributor

The /music lyrics panel stopped lighting lines: /clock answered duration: 0 for every AI label station on server2, and tick() in web/src/music.ts returns before highlight() when the duration is 0.

Cause: the AI label stations play hard links under ~/Downloads/ai-radio, which no library source covers (sources are ~/Downloads/done and ~/Downloads/Downloads/done). durationOf only asked the library index.

Fix: durationOf falls back to DurationProbe (track-facts.ts), a cached background ffprobe keyed by size+mtime. The first clock answer may still be 0; the player asks again every 2 s and gets the length then.

Tests: new track-facts test (stub ffprobe), station tests 25/25, tsc clean, pack:cli OK.

🤖 Generated with Claude Code

… karaoke lyrics follow again (0.80.4)

The AI label stations play hard links under ~/Downloads/ai-radio, which no
library source covers. durationOf only asked the library index, so /clock
answered duration 0 and the /music player stopped before highlighting the
synced lyrics (and hid the progress bar). durationOf now falls back to a
cached background ffprobe; the player re-asks the clock every 2 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

ThreatCrush Security Scan

12 finding(s) in the 4 file(s) this pull request changes.

HIGH: 11 | MEDIUM: 1

Severity Rule Location
HIGH js-host-header-trust src/server.ts:3133
HIGH js-host-header-trust src/server.ts:3147
HIGH js-host-header-trust src/server.ts:3164
HIGH js-host-header-trust src/server.ts:3173
HIGH js-host-header-trust src/server.ts:3178
HIGH js-host-header-trust src/server.ts:3281
HIGH js-host-header-trust src/server.ts:3347
HIGH js-host-header-trust src/server.ts:3434
HIGH js-host-header-trust src/server.ts:3462
HIGH js-host-header-trust src/server.ts:3632
HIGH js-host-header-trust src/server.ts:3648
MEDIUM redos-nested-quantifier src/server.ts:4845
44 pre-existing finding(s) elsewhere in the repository — **HIGH**: 6 | **MEDIUM**: 14 | **LOW**: 24

Not introduced by this pull request.

Severity Rule Location
HIGH secret-database-url .github/workflows/translation.yml:31
HIGH secret-generic-credential src/hls.ts:81
HIGH js-ssrf-outbound-request src/music-hub.ts:304
HIGH js-ssrf-outbound-request web/src/app.ts:115
HIGH js-ssrf-outbound-request web/src/app.ts:163
HIGH js-ssrf-outbound-request web/src/app.ts:167
MEDIUM js-unescaped-html-sink backtoschool/src/main.ts:95
MEDIUM js-unescaped-html-sink backtoschool/src/main.ts:241
MEDIUM js-unescaped-html-sink backtoschool/src/main.ts:257
MEDIUM js-unescaped-html-sink backtoschool/src/main.ts:281
MEDIUM js-unescaped-html-sink backtoschool/src/main.ts:366
MEDIUM js-unescaped-html-sink backtoschool/src/main.ts:494
MEDIUM js-unescaped-html-sink web/src/app.ts:391
MEDIUM js-unescaped-html-sink web/src/app.ts:392
MEDIUM js-timing-unsafe-mac-compare web/src/app.ts:2454
MEDIUM js-open-redirect web/src/app.ts:3869
MEDIUM js-unescaped-html-sink web/src/app.ts:7376
MEDIUM js-unescaped-html-sink web/src/control-icons.ts:19
MEDIUM insecure-randomness-for-secret web/src/music.ts:419
MEDIUM insecure-randomness-for-secret web/src/station.ts:314

…and 24 more; the full set is in the SARIF artifact.

Snippets are redacted; ThreatCrush never prints matched credential material.

@ralyodio
ralyodio merged commit 8420b51 into main Nov 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant