review: build the storage params sparse at one site - #124
Merged
Conversation
From the simplify-round adjudication of #122. The cli had two idioms for a plugin params map — node add builds under IsSet guards while the four workload paths filled every key and compacted after — and CompactParams was the patch reconciling the second to the first. StorageParams now builds the storage request sparse in one place, the four sites become one-liners, CompactParams leaves the exported surface, and the lambda test states the expected presence in its table instead of re-deriving it from the other columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the simplify-round adjudication of #122.
The cli had two idioms for a plugin params map —
node addbuilds underIsSetguards while the four workload paths filled every key and compacted after — andCompactParamswas the patch reconciling the second to the first.StorageParamsnow builds the storage request sparse in one place, the four call sites become one-liners,CompactParamsleaves the exported surface, and the lambda test states the expected presence in its table instead of re-deriving it from the other columns. Wire output is unchanged (regression tests kept).