Skip to content

fix: align Spring smoke test protobuf runtime - #2385

Draft
zeitlinger wants to merge 2 commits into
prometheus:mainfrom
zeitlinger:agent/fix-spring-protobuf-runtime
Draft

fix: align Spring smoke test protobuf runtime#2385
zeitlinger wants to merge 2 commits into
prometheus:mainfrom
zeitlinger:agent/fix-spring-protobuf-runtime

Conversation

@zeitlinger

Copy link
Copy Markdown
Member

Summary

  • pin the Spring Boot smoke test's Protobuf runtime to the version used to generate the client sources
  • manage the dependency explicitly so Renovate can keep the test version aligned on future Protobuf updates

Root cause

The Spring Boot parent currently manages protobuf-java at 4.34.2, while the client sources are generated with 4.35.1. During a reactor test, Maven uses the exposition module's target/classes before shading, so the generated 4.35.1 classes load against Spring Boot's older 4.34.2 runtime and fail the runtime compatibility check.

Published artifacts remain shaded; this change only aligns the reactor smoke-test classpath.

Validation

  • reproduced on main with ./mvnw clean test -pl integration-tests/it-spring-boot-smoke-test -am -Dcoverage.skip=true -Dwarnings=-nowarn
  • mise run lint:fix
  • mise run test

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant