Repository navigation
Conversation
Do not discard a finite maximum merely because a child prefers zero. Keep hidden zero-size dimensions ignored and add real layout regressions. AI assistance: OpenAI Codex.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 21:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_layout_dimensionstreats every zero-preferred dimension as empty, discarding its finite maximum. WrappingWindow(width=Dimension(max=10, preferred=0))in anHSplittherefore removes its 10-column cap: an adjacentVSplitassigns it 40 columns out of 80 instead of 10.Ignore only dimensions whose maximum is zero. Preserve explicit finite caps while retaining the existing rule that other children's larger preferred sizes take precedence. Invisible children still cannot shrink visible siblings.
Add eleven tests covering a lone cap, default/invisible siblings, multiple caps, positive preferred siblings, empty inputs and a real nested split. Eight regressions fail on unchanged source.
Validation on Linux / Python 3.12.14:
git diff --checkpass.Other interpreter/native OS and hosted CI results are not claimed. Prepared and tested with OpenAI Codex assistance; no human review is claimed.