Repository navigation
Conversation
Recognize whitespace consistently with the existing splitter and trimmer, so tabs and Unicode separators enter the nested completion branch. AI assistance: OpenAI Codex.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 21:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestedCompleteruses whitespace-aware splitting and trimming, but only enters its nested-routing branch when it finds an ASCII space.show\tandshow\ntherefore suggest root commands instead of child commands; partial nested words and deeper levels fail too.Recognize whitespace with
str.isspace()in that guard, leaving key matching, child completers and cursor offsets unchanged. Add 29 cases for ASCII/Unicode separators, leading whitespace, partial words, cursor suffixes, unknown/terminal commands and multiple levels.This is independent of #2120's case-insensitive key lookup, which leaves the separator guard unchanged. All new routing examples use exact-case command names.
Validation on Linux / Python 3.12.14:
Other interpreters/native OS and hosted CI results are not claimed. Prepared and tested with OpenAI Codex assistance; no human review is claimed.