Repository navigation
Conversation
Keep the default sentinel out of RGB parsing and cover parsed styles and both brightness directions. AI assistance: OpenAI Codex.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 22:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid
fg:defaultstyle crashesAdjustBrightnessStyleTransformationbecause its terminal-default sentinel is passed to RGB parsing. This can prevent printing or rendering whenever brightness adjustment is enabled.Preserve
defaultforegrounds alongside the existingansidefaulthandling. Ten new cases cover both brightness directions, explicit style parsing, default backgrounds, and None/empty/ANSI-default controls. Four reproduce the original crash.Validation on Linux/Python 3.12:
Other Python/native OS combinations and hosted CI are not claimed. Prepared and tested with AI assistance (OpenAI Codex); no human review is claimed.