Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 17, 2026 03:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve asynchronous completion when
FuzzyCompleterwraps a completer with a customget_completions_asyncimplementation. Previously, the inherited async method called the synchronous path, so async-only completers could fail or return no results, and a wrappedThreadedCompleterran its work on the event-loop thread.The async path now awaits the wrapped completer, then uses the same fuzzy matching and sorting logic as the synchronous path. With fuzzy matching disabled, it forwards async results directly. Wrapped async generators are closed on cancellation, errors, and early termination.
Verification
Prepared with Codex assistance. Remote CI has not yet run for this change.