Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 18, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TabsProcessor uses the transformed string index to calculate tab stops. String indexes and terminal columns differ after double-width and combining characters. For example, with tabstop=4,
界\tbcurrently expands to界 b, placingbin terminal column 5 instead of 4.Change
Track terminal columns separately from transformed string positions. Use the renderer's cached character widths, including control-character display mappings, to determine the next tab stop while keeping source/display mappings expressed as string indexes. Preserve zero-width escape fragments without counting or expanding their contents.
Regression coverage
Cover ASCII, wide characters before the first and repeated tabs, a wide-character sequence ending exactly on a tab stop, combining characters, C0/C1 control-character rendering, and zero-width escape sequences (including a literal tab inside an OSC sequence). Check the expanded text and both cursor-position mappings, including positions inside tab expansion.
AI-assisted implementation; the patch and test results were reviewed.
Validation
Commands run successfully against the final tree:
Packaging validation:
.venv/bin/python -m buildpassed in an isolated build environment and produced both the sdist and wheel. Setuptools emitted deprecation warnings concerning upstream license classifiers; the build completed successfully.