Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 18, 2026 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HighlightMatchingBracketProcessor compares a transformed display column with the original cursor column, without checking the source row. For
(\n), both brackets receive the cursor style when the cursor is on either bracket. When a previous processor inserts a prefix, the bracket under the cursor instead receives the other-bracket style.Change
Determine whether a bracket is under the cursor using its source row and column, before mapping its column into display coordinates.
Regression coverage
Test the cursor on either bracket of a multiline pair, both without a prefix and with a source-to-display offset. Also preserve the existing other-bracket style when the cursor is immediately after the closing bracket, for single-line and multiline pairs.
AI-assisted implementation; the patch and test results were reviewed.
Validation
Commands run successfully against the final tree:
Packaging validation:
.venv/bin/python -m buildpassed in an isolated build environment and produced both the sdist and wheel. Setuptools emitted deprecation warnings concerning upstream license classifiers; the build completed successfully.