Repository navigation
Escape quotes and 8-bit CSI in HTML.format and ANSI.format - #2148
Merged
jonathanslenders merged 1 commit intoOct 20, 2026
Merged
jonathanslenders merged 1 commit into
jonathanslenders merged 1 commit into
Conversation
jonathanslenders
approved these changes
Oct 20, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The escape helpers behind
HTML.format/%andANSI.format/%miss characters that their own parsers treat as markup, so an interpolated value can still change the output:html_escapeleaves'alone:HTML("<style fg='{}'>x</style>").format("red' bg='blue")sets a background, and a plain apostrophe in a single-quoted attribute raisesExpatErroransi_escapeleaves\x9balone, which the ANSI parser accepts as CSI:ANSI("{}").format("\x9b31mred")recolors the text\001/\002alone, which wraps the value in a[ZeroWidthEscape]fragment that the renderer writes to the terminal unprocessedBoth helpers now neutralize those characters the same way they already handle
"and\x1b. Existing interpolation tests pass unchanged, since expat decodes'back to'.