Repository navigation
Create FileHistory file with owner-only permissions - #2156
Open
neeraj1235476 wants to merge 1 commit into
Open
neeraj1235476 wants to merge 1 commit into
neeraj1235476 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileHistory.store_stringcreates the history file withopen(filename, "ab"), so under the usual 022 umask it ends up 0644 and any local user can read it. That file holds everything typed at the prompt, and for tools built onFileHistory(pgcli, mycli, ptpython) that includes SQL with passwords, tokens and connection strings. GNU readline, and therefore psql and bash, create their history files 0600.Create the file with
os.open(..., 0o600)so a new history file is owner-only. Files that already exist keep their mode, andO_BINARYkeeps the Windows behaviour the same as before. Doing this insideFileHistorymeans each application doesn't have to pre-create the file or adjust its umask.test_file_history_permissionsin tests/test_history.py fails before this change and passes after it.