Add sideways chart previews to the existing unlisted impact page - #156
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the existing cryptic preview, without launching field velocity
Targets
mainafter #154 and the existing/impact-preview-eb61fba1b98e/route. This is the PR to merge for the slide effect on that page. Draft #155 is separate and remains the future public-detail switch-on.Latest refinement: whiter inactive cards
Per Lukas's follow-up, unselected cards displaced to the side now fade toward white in light mode, rather than receiving a darker gray mask. Dark mode retains its exact original mask. The veil does not intercept clicks; no chart, geometry, data or route logic changed in this refinement.
Local candidate gallery crop, showing the CSS included in
14def61. The old gray-mask screenshots in the history are superseded.Slide behavior
/impact/promotion or discovery links added.Verified
14def61661145dd6dee8bbd090bd2b617e1e9f67: 85 tests, TypeScript, production build, diff check and independent incremental review PASS. The first local build hit process-spawnEAGAIN; the isolated retry passed without source changes.Before: overlay fan
Interactive deployment preview · Detailed scope and screenshot provenance