Refactor the serialization code generation. - #29652
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Conversation
copybara-service
Bot
force-pushed
the
test_977500229
branch
from
September 8, 2026 14:26
acb8608 to
83cff25
Compare
The code emitting proto serialization functionality used to be a state machine greedily forming the chunks and emitting them in a single loop. At the same time other generators in message.cc follow the two-stage approach, where the chunks are formed first and only then emitted. This change adopts the two-stage approach for the serialization generator. PiperOrigin-RevId: 977500229
copybara-service
Bot
force-pushed
the
test_977500229
branch
from
September 9, 2026 09:51
83cff25 to
ee74543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the serialization code generation.
The code emitting proto serialization functionality used to be a state machine greedily forming the chunks and emitting them in a single loop. At the same time other generators in message.cc follow the two-stage approach, where the chunks are formed first and only then emitted.
This change adopts the two-stage approach for the serialization generator.