Repository navigation
Fix stale Cord and extension sections in the Rust generated code guide. - #340
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1006655663
branch
from
November 10, 2026 09:57
dafc0e5 to
0060520
Compare
copybara-service
Bot
changed the title
Update the `[ctype = CORD]` section to remove a stale note that Cords are not implemented, clarify that `ProtoStringCow`/`ProtoBytesCow` are generated on the C++ kernel while the upb kernel uses standard string/bytes accessors, and fix the field names and code block fence. Update the extensions section so the `protobuf::ExtensionId` path, method trait bounds (`AsView`/`IntoView`/`AsMut`/`IntoMut`), and example constant names (`I32_EXT` and `REPEATED_I32_EXT`) match the generated Rust API. PiperOrigin-RevId: 1018031781
copybara-service
Bot
force-pushed
the
test_1006655663
branch
from
November 10, 2026 09:58
0060520 to
51aa6af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale Cord and extension sections in the Rust generated code guide.
Update the
[ctype = CORD]section to remove a stale note that Cords are notimplemented, clarify that
ProtoStringCow/ProtoBytesCoware generated on theC++ kernel while the upb kernel uses standard string/bytes accessors, and fix
the field names and code block fence.
Update the extensions section so the
protobuf::ExtensionIdpath, method traitbounds (
AsView/IntoView/AsMut/IntoMut), and example constant names(
I32_EXTandREPEATED_I32_EXT) match the generated Rust API.