Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dedicated road shields for Germany and Japan, following the existing US / NL pattern.
Germany
BABBAB-{1–5}charDE:nationalDE:national-{1–5}charJapan
JP:EalsoJP:national:expresswayJP:E-{1–5}charJP:nationalJP:national-{1–5}charJP:prefecturalandJP:prefectural:<prefecture>JP:prefectural-{1–5}charJapan National highway shields also get a small
icon-offsetso the ref sits in the visual correct position of the shield.Sprites
25 new groups in
sprites/refill.svg(_BAB-*,_DE:national-*,_JP:national-*,_JP:prefectural-*,_JP:E-*), registered asbasein all fivesprites/flavors/*.json.I used Adobe Illustrator to edit the SVG since it looked like it had initially been created using Illustrator. When exporting, Illustrator rewrote the style class names from 'cls-N' to 'stN' in the SVG. I tried differen export settings but the result where always the same. This is probably because I used a newer version of Illustrator (CC 2026). That's why there are more code changes to the SVG than just the new shields. This doesnt affect any functionality the assets are generated normally, and all icons look the same as before.
All new road shields vectors are created by myself.
I checked the map in all flavors and all shields are looking like intended.
If you have any feedback on the look of the signs, please let me know, and I can make some adjustments.
Here some reference for you:
This is a German sign featuring an Autobahn badge (white on blue) and a Bundesstraße badge (black on yellow):
https://commons.wikimedia.org/wiki/Category:SVG_road_signs_in_Germany#/media/File:Zeichen_434-51_-_Tabellenwegweiser_teilaufgel%C3%B6ste_Form_(nach_RWBA),_StVO_2017.svg
Here is an example of Japanese road signs (Figure 118) on the right:
https://www.mlit.go.jp/road/sign/sign/douro/ichiran.pdf