Skip to content

Remove implicit system crypto forcing on s390x #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
surenderky wants to merge 1 commit into from
Closed

Remove implicit system crypto forcing on s390x #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Test

Check warning on line 15 in .github/workflows/test.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

test.yml:15: overly broad permissions: default permissions used due to no permissions: block

on:

Expand Down Expand Up @@ -40,7 +40,7 @@

jobs:

test_data:

Check warning on line 43 in .github/workflows/test.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

test.yml:43: overly broad permissions: default permissions used due to no permissions: block
name: build test data

runs-on: ubuntu-24.04
Expand Down Expand Up @@ -88,7 +88,7 @@
if-no-files-found: error
retention-days: 3

build:

Check warning on line 91 in .github/workflows/test.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

test.yml:91: overly broad permissions: default permissions used due to no permissions: block
name: ${{ matrix.action }} with ${{ matrix.name }}

needs: test_data
Expand Down Expand Up @@ -244,7 +244,7 @@
os: ubuntu-24.04
arch: s390x
action: test
flags: --config=clang --test_timeout=1800
flags: --config=clang --define=crypto=system --test_timeout=1800
# s390x build-tools image built from bazel/external/Dockerfile.bazel
run_under: docker run --rm --env HOME=$HOME --env USER=$(id -un) --volume "$HOME:$HOME" --workdir $(pwd) --user $(id -u):$(id -g) --platform linux/s390x ghcr.io/proxy-wasm/build-tools:ubuntu-24.04-bazel-7.7.1
cache: true
Expand Down
16 changes: 1 addition & 15 deletions bazel/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

load("@bazel_skylib//lib:selects.bzl", "selects")
load(":v8_transition.bzl", "v8_lib_no_pointer_compression")

package(default_visibility = ["//visibility:public"])
Expand Down Expand Up @@ -53,21 +52,8 @@ config_setting(
)

config_setting(
name = "requested_crypto_system",
values = {"define": "crypto=system"},
)

config_setting(
name = "linux_s390x",
values = {"cpu": "s390x"},
)

selects.config_setting_group(
name = "crypto_system",
match_any = [
":requested_crypto_system",
":linux_s390x",
],
values = {"define": "crypto=system"},
)

# V8 library with pointer compression disabled using V8's Starlark transition.
Expand Down
Loading