Repository navigation
PlayStation Eye Sample addition - #174
Conversation
|
TheMrIron2
left a comment
TheMrIron2
left a comment
There was a problem hiding this comment.
It's good that we're fixing up the old camera sample. I can't test this on a camera myself. I left two code comments and I have a more general one.
This sample is written entirely around tiny3D. That would probably be fine for a homebrew app, but tiny3D is a legacy abstraction. I'd rather avoid the precedent of using a legacy library for new samples. Since this sample is meant to demonstrate the camera API, I think it would be better to use our native RSX interfaces like the existing camera sample.
It should also be added to the higher level makefile at samples/input/Makefile once it's done.
|
|
||
| void LoadTexture() | ||
| { | ||
| u32 * texture_mem = tiny3d_AllocTexture(48*1024*1024); |
There was a problem hiding this comment.
Is a 48MB allocation necessary for a 640x480 frame?
| u32 readcount = 0; | ||
|
|
||
| cameraRead(0, &frame, &readcount); | ||
| UpdateCameraTexture((const u8 *)(u64)camInfo.buffer); |
There was a problem hiding this comment.
The current code is calling UpdateCameraTexture even when cameraRead fails or has no new data.
|
I mean idk, I mainly used stuff from my acidsamplev2. and tbh, im not really familiar with actual memory allocation since im still in a beginner level (I suppose)😔 |
|
ok i updated stuff i think the 4mb allocation is good😅 |
|
Thanks. Both of your changes fix the comments I left. 4MB seems fine. Unfortunately, we still can't accept the PR until tiny3D is gone. Tiny3D is a Out of interest, what was the problem you found with the original camera sample? I can't test it, and I can see the code is very old, but I would be interested to know what's wrong with it today. |
|
oh. so I couldn't compile the old sample due to outdated components and functions. I'll try to convert the tiny3d stuff to gcm once I get home😅😅 |
|
ok now it works without tiny3d! :> |
bucanero
left a comment
bucanero
left a comment
There was a problem hiding this comment.
LGTM
@TheMrIron2 the sample is now using gcm and not tiny3d , I think it's good to go
TheMrIron2
left a comment
TheMrIron2
left a comment
There was a problem hiding this comment.
LGTM too. Thanks for following the requested changes.
With the power of AI, I was able to make the PlayStation Eye work properly on a PSL1GHT environment. So it would probably be something good to include in the samples, because the current camera samples are heavily outdated.
