Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache-Control values such as
max-age="600"are currently discarded during numeric parsing. A fresh response can therefore be fetched from the origin again, and a request withmax-age="0"can miss the cache-bypass path.I remove one balanced pair of double quotes before the existing integer conversion for numeric directives. This follows the recipient-tolerance guidance in RFC 9111 section 5.2; it does not change the sender's token-form requirement. Malformed values retain the existing handling, and the freshness/Age calculations are unchanged.
Validation: 152 tests passed, including real HTTP cached-body replay and quoted request bypass; the regression selection has 15 failures against the original source. Ruff lint and MyPy pass. The coverage run retains a Cheroot cleanup warning also reproduced on the original source. Existing codespell findings and an unrelated controller docstring-format finding are unchanged.