Skip to content

subscribe listenr callback update to handle unknown event types - #508

Open
mohitpubnub wants to merge 1 commit into
masterfrom
CLEN-3690
Open

subscribe listenr callback update to handle unknown event types#508
mohitpubnub wants to merge 1 commit into
masterfrom
CLEN-3690

Conversation

@mohitpubnub

@mohitpubnub mohitpubnub commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

fix(listeners): discard unknown event types

No listener callback will be triggered for event with unknown event types

fix: all events from presence channels will be categorised as presence event

all events from the presence channels will be categorised as presence event

…nt type, delivery all the events coming through pnpres channels to presence call back
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • package-lock.json is excluded by !**/package-lock.json, !package-lock.json and included by none
  • src/core/endpoints/subscribe.ts is excluded by none and included by none
  • test/unit/subscribe-event-categorisation.test.ts is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3639d4c3-1c1c-46ef-a00c-b2615792e523

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pubnub-ops-terraform

pubnub-ops-terraform commented Aug 31, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants