Repository navigation
feat: added anti-corruption layer for login entities - #384
Merged
Merged
Conversation
Redtigercod4
force-pushed
the
feat/login-entities
branch
from
October 16, 2026 19:59
90285d6 to
a7a3f99
Compare
Redtigercod4
added
enhancement
Redtigercod4
marked this pull request as ready for review
October 22, 2026 13:44
Redtigercod4
force-pushed
the
feat/login-entities
branch
from
October 29, 2026 14:23
7789497 to
01537fc
Compare
…c auth popup on 400 response
Redtigercod4
force-pushed
the
feat/login-entities
branch
from
October 29, 2026 14:37
01537fc to
86882b8
Compare
Contributor
Author
|
Reviewed using Anthropic Opus 5 Model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the anti-corruption layer (ACL) for both
core/loginandcore/statusentities, building on from the@pulp-ui/sdkbindings. The SDK has now been configured to produce Zod schemas instead of TypeScript interfaces to enable the use of Zod codecs in a domain-driven pattern. Having this thin layer for each entity client, it means everything can be controlled in one location so that API changes are easily absorbed and issues rectified.To ensure the SDK is consumable by the root project, it now compiles into a
/distfolder under TypeScript 7.Changes
loginclient and models by addingLogintag to orval.src/entities/core/statusandsrc/entities/core/login, each with aclient.tsandmodel.tsstructure.preparestep to allow SDK to be built prior to installation by root project.Out of Scope
Linked Issues & Epics
Epic: pulpcore
AI Assistance
Claude (Sonnet 5) was consulted during development for discussions, suggestions and research. All code was written and reviewed by author.
Sources