Repository navigation
feat: adds a hardened, per job-concern model for all pull requests - #397
Merged
Merged
Conversation
Redtigercod4
force-pushed
the
feat/gh-actions
branch
from
October 30, 2026 11:00
8cc361f to
732e31c
Compare
Redtigercod4
marked this pull request as ready for review
October 30, 2026 12:02
ggainey
approved these changes
Oct 30, 2026
ggainey
left a comment
Collaborator
There was a problem hiding this comment.
Looks much easier to find/maintain the individual steps. Secures GH-action usage in useful ways, considering the current SDLC environment. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #362 for Pull Requests against the
mainbranch, moving from the previouspr-checks.ymlto a per-job concern reusable workflow approach. Based on OWASP CI/CD Top 10 recommendations, this approach now implements SAST, SCA and further testing within the project. It also now takes advantage of the new github actionsaction-lockfeature for ensuring actions are now versioned correctly.Changes
pr-check.ymltopull-request.ymloverhauling it with reusable workflows and the inline merge-commit check.sarif-upload.ymlworkflow withinmainto allow CodeQL and overSARIFproducing actions to upload to the Pull request with the correct permissions.actions.lockfor version control of github actions.zizmor.ymlfor documentation overrides against recommended controls within the actions.osv-scanner.tomlfor documenting knownCVEswithin dependencies that currently can not be addressed.Out of Scope
Cypress.yml into a dedicated reusable workflow.main.yml/schedule.yml/release.ymlrestructuring under Proposal: Overhaul PulpUI Github Actions to a hardened, per job-concern model. #362secrets-scanningis wired but disabled. See blockers.Blockers
gitleaks/gitleaks-actionis blocked by a Pulp Organisation actions allow-list. Chore: gitleaks/gitleaks-action blocked by org Actions allow-list policy #398Linked Issues & Epics
AI Assistance
Consulted Claude (Sonnet 5) through for verifying design decisions and debugging pipeline failures. Pull Request was peer reviewed by Claude (Sonnet 5.5) & OpenAI (GPT-6).
Sources