Repository navigation
Fix flaky test on test_cdn_cache_validation - #8294
Merged
Merged
Conversation
aiohttp.FileResponse replaces Pulp's last modified with the last modified timestamp of the file stats. Not only that, but it rounds to the NEXT second, which caused the last modified to be in the future! This behavior is problematic, so this commits points to a more broad issue about it and applies a workaround to avoid the flaky test.
dralley
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiohttp.FileResponse replaces Pulp's last modified with the last modified timestamp of the file stats. Not only that, but it rounds to the NEXT second, which caused the last modified to be in the future!
This behavior is problematic, so this commits points to a more broad issue about it and applies a workaround to avoid the flaky test.
📜 Checklist
See: Pull Request Walkthrough