Skip to content

Return Int for scrollWidth and scrollHeight #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomashoneyman merged 1 commit into from
Oct 10, 2026
Merged

Return Int for scrollWidth and scrollHeight #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Notable changes to this project are documented in this file. The format is based
## [Unreleased]

Breaking changes:
- The `scrollWidth` and `scrollHeight` functions return `Int` instead of `Number`. (#55)
- The `id` function returns an `ElementId` instead of a `String`. (#58 by @nsaunders)
- The `setId` function is parameterized by `ElementId` instead of `String`. (#58 by @nsaunders)
- The `getElementById` function is parameterized by `ElementId` instead of `String`. (#58 by @nsaunders)
Expand Down
4 changes: 2 additions & 2 deletions src/Web/DOM/Element.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ foreign import setScrollTop :: Number -> Element -> Effect Unit
foreign import scrollLeft :: Element -> Effect Number
foreign import setScrollLeft :: Number -> Element -> Effect Unit

foreign import scrollWidth :: Element -> Effect Number
foreign import scrollHeight :: Element -> Effect Number
foreign import scrollWidth :: Element -> Effect Int
foreign import scrollHeight :: Element -> Effect Int
foreign import clientTop :: Element -> Effect Number
foreign import clientLeft :: Element -> Effect Number
foreign import clientWidth :: Element -> Effect Number
Expand Down
Loading