Repository navigation
Migrate to Spago and update CI - #129
Open
thomashoneyman wants to merge 13 commits into
Open
thomashoneyman wants to merge 13 commits into
thomashoneyman wants to merge 13 commits into
Conversation
natefaubion
reviewed
Oct 15, 2026
Comment on lines
+27
to
+39
| Run `npm run build:benchmark` and `npm run test:benchmark` to run all four workloads. | ||
| The runner uses Minibench with garbage collection before each measurement series | ||
| and allows a 2.5 GiB old-generation Node heap for the three-million-bind cases. | ||
| To save JSON results, run | ||
| `npm run --silent test:benchmark > /tmp/free-benchmarks.json`; progress goes to stderr. | ||
| Timings include both bind construction and trampoline execution over each input | ||
| batch. Short cases group repeated batches to reduce timing noise. Results record | ||
| sample, warm-up and repetition counts, with timings normalized to seconds per | ||
| batch; the deviation and min/max describe these normalized samples. | ||
| The deterministic zero-array inputs and historical implementations are unchanged. | ||
| The sampling method differs from Benchotron, so these measurements are not directly | ||
| comparable to the historical results below. | ||
|
|
Member
Author
There was a problem hiding this comment.
Hey, I wrote this by hand
Member
Author
There was a problem hiding this comment.
I'm similarly inclined to just take this all out.
natefaubion
requested changes
Oct 15, 2026
natefaubion
left a comment
natefaubion
left a comment
Contributor
There was a problem hiding this comment.
I think the benchamrk additions to the README are silly. In general, I'm inclined to remove the historical benchmarks and references. It's fine to have a minibench one, but inlining an implementation of Benchotron is kind of over-the-top and unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
freefrom Bower/Pulp to Spago and updates CI. The registry deprecated support for Bower-based packages in September 2023, and as of September 1, 2026 it no longer promises any long-term support. To accommodate the change, this upgrades us to the officially-supportedspagopackage manager.I also updated CI and our format/linting. Each change is in separate commits.
This will be released as version
7.1.1because the library code is unchanged beyond formatting, and the dependencies match what is already in the registry for7.1.0. There are no unreleased API changes since that tag.The benchmarks and their historical results have been removed. Library code and tests are unchanged by that removal.