Repository navigation
Handle empty channel list returned as an array in getChannels - #409
Open
mkantautas wants to merge 1 commit into
Open
mkantautas wants to merge 1 commit into
mkantautas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getChannels() passes channels to get_object_vars() without checking its type. Servers that build the response from a PHP array, such as Laravel Reverb, return an empty JSON array for channels when no channel is occupied or none matches filter_by_prefix. On PHP 8 this throws a TypeError; on PHP 7 it warns and sets channels to null.
This adds the is_object() check that process_trigger_result() already uses, so an empty list stays []. Object-form channel responses are unchanged.
Fixes #408
Tested: a new unit test covers a channels object, an empty object and an empty array. It fails on master and passes with the fix on PHP 7.3 to 8.5 with prefer-lowest and prefer-stable; phplint passes. Acceptance tests were not run (they need a Pusher app).
CHANGELOG