Repository navigation
Use BuildConfig instead of reading version from properties file - #349
Merged
Merged
Conversation
Author
|
Do I need to update the |
# Conflicts: # build.gradle
Contributor
|
Thanks for the PR, @daniel-shuy, and sorry for the wait. No version bump needed, since that's handled by our release process. I've merged master to resolve the build.gradle conflict. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
============================================
+ Coverage 74.65% 75.43% +0.77%
- Complexity 363 373 +10
============================================
Files 48 48
Lines 1965 1970 +5
Branches 145 148 +3
============================================
+ Hits 1467 1486 +19
+ Misses 433 421 -12
+ Partials 65 63 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Keith-wright
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #288
Use com.github.gmazzo.buildconfig Gradle plugin (a plugin that generates
BuildConfiglike the Gradleandroidplugin, but for non-Android Java projects) to generateBuildConfigwith project version at build time, instead of reading frompusher.propertiesat runtime, which fails withDiskReadViolationwhen running on Android with StrictMode enabled.CHANGELOG
BuildConfiginstead of reading version from properties file