Repository navigation
Fix: Add configurable TLS version support to PusherOptions - #375
Closed
mouadh-dev wants to merge 1 commit into
Closed
mouadh-dev wants to merge 1 commit into
mouadh-dev wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR, @mouadh-dev. A lot of it has since landed separately. #377 updated the build and workflows, and #359 added the custom SSL socket factory. That leaves the TLS version option as the only new change here. If you’d still like that option, could you open a new PR against the current master with just the TLS change? Please describe the use case in the description, for example which servers or environments need a specific TLS version, and add tests. Please leave out the build.gradle, Gradle wrapper and version changes, since the version is managed by our release process. I’ll close this one in the meantime. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Description here]
CHANGELOG