Skip to content

Maint: Normalize line endings and add .gitattributes#2805

Open
Aditya-myst wants to merge 2 commits into
pvlib:mainfrom
Aditya-myst:fix/line-endings-normalization
Open

Maint: Normalize line endings and add .gitattributes#2805
Aditya-myst wants to merge 2 commits into
pvlib:mainfrom
Aditya-myst:fix/line-endings-normalization

Conversation

@Aditya-myst

@Aditya-myst Aditya-myst commented Jul 4, 2026

Copy link
Copy Markdown

Fixed issue #2802 by adding * text=auto to .gitattributes and renormalizing the repository to ensure consistent LF line endings
As requested, here's the completed PR checklist.

  • Closes [Maint] Line ending normalization wrong in some files #2802
  • I am familiar with the contributing guidelines.
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license.
  • Tests added (Not applicable. This change only adds .gitattributes and renormalizes line endings. The changes were verified locally using Git CLI.)
  • Updates entries in docs/sphinx/source/reference for API changes. (Not applicable.)
  • Adds description and name entries in the appropriate "what's new" file. (Not applicable; no user-facing or API changes.)
  • New code is fully documented. (Not applicable; no new source code.)
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Summary

This PR fixes #2802 by adding * text=auto to .gitattributes and renormalizing the repository to ensure consistent LF line endings across platforms. I verified the changes locally using Git CLI to confirm that only line-ending normalization was applied and no unintended content changes were introduced.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Hey @Aditya-myst! 🎉

Thanks for opening your first pull request! We appreciate your
contribution. Please ensure you have reviewed and understood the
contributing guidelines.

If AI is used for any portion of this PR, you must vet the content
for technical accuracy.

@echedey-ls

Copy link
Copy Markdown
Member

Please, add and fill out the PR checklist template to your comment. It's under .github folder.

@Aditya-myst

Copy link
Copy Markdown
Author

As requested, here's the completed PR checklist.

  • Closes [Maint] Line ending normalization wrong in some files #2802
  • I am familiar with the contributing guidelines.
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license.
  • Tests added (Not applicable. This change only adds .gitattributes and renormalizes line endings. The changes were verified locally using Git CLI.)
  • Updates entries in docs/sphinx/source/reference for API changes. (Not applicable.)
  • Adds description and name entries in the appropriate "what's new" file. (Not applicable; no user-facing or API changes.)
  • New code is fully documented. (Not applicable; no new source code.)
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Summary

This PR fixes #2802 by adding * text=auto to .gitattributes and renormalizing the repository to ensure consistent LF line endings across platforms. I verified the changes locally using Git CLI to confirm that only line-ending normalization was applied and no unintended content changes were introduced.

@echedey-ls echedey-ls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that you put that checklist on your very first comment, the one at the top of the pull request. It's for traceability and saving time to readers. Thanks.

I have not yet confirmed all the big changes, will do at some point.

Comment thread .gitattributes Outdated
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maint] Line ending normalization wrong in some files

2 participants