Remove unused clearsky._is_leap_year (closes #2768)#2813
Open
dgowdaan-cmyk wants to merge 3 commits into
Open
Conversation
Author
|
@cwhanse This is ready for review whenever you get a chance. Summary of the change:
Let me know if anything else is needed on my end |
cwhanse
approved these changes
Jul 7, 2026
|
|
||
| Maintenance | ||
| ~~~~~~~~~~~ | ||
| * Removed unused internal function ``clearsky._is_leap_year`` (:issue:`2768`, :pull:`XXXX`) |
Member
There was a problem hiding this comment.
Suggested change
| * Removed unused internal function ``clearsky._is_leap_year`` (:issue:`2768`, :pull:`XXXX`) | |
| * Removed unused internal function ``clearsky._is_leap_year`` (:issue:`2768`, :pull:`2813`) |
Comment on lines
+46
to
+50
|
|
||
| Contributors | ||
| ~~~~~~~~~~~~ | ||
|
|
||
| * Darshan Gowda (:ghuser:`dgowdaan-cmyk`) |
Member
There was a problem hiding this comment.
Suggested change
| Contributors | |
| ~~~~~~~~~~~~ | |
| * Darshan Gowda (:ghuser:`dgowdaan-cmyk`) |
The heading is four lines below. Please move your ID to that list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2768
Removes the unused internal function
clearsky._is_leap_year. Verified via repo-wide search that it has no other references anywhere in the codebase. Per maintainer (@cwhanse), no deprecation cycle or new test required — see comment.docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:numor this Pull Request with `:pull:`num. Includes contributor name and/or GitHub username (link with:ghuser:user``).remote-data) and Milestone are assigned to the Pull Request and linked Issue.