Mark the package as Production/Stable - #904
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
laughingman7743
commented
Sep 30, 2026
| license-files = ["LICENSE", "NOTICE"] | ||
| classifiers = [ | ||
| "Development Status :: 4 - Beta", | ||
| "Development Status :: 5 - Production/Stable", |
Member
Author
There was a problem hiding this comment.
Self-review round one (implementation behavior)
- Perspective: behavior/failure paths, resource boundaries, framework contracts, simplicity and test quality.
- Base: 8679f04, head: 6585bbd
- Covered: the one-line classifier change;
git grepfor other readers of classifiers or the development status. The only hits are.github/workflows/test.yaml:95(Python version classifiers, unrelated) andbenchmarks/pyproject.toml:14(Private :: Do Not Upload, a separate project). No runtime code reads the classifiers. - Result: CLEAN, no repairs.
| license-files = ["LICENSE", "NOTICE"] | ||
| classifiers = [ | ||
| "Development Status :: 4 - Beta", | ||
| "Development Status :: 5 - Production/Stable", |
Member
Author
There was a problem hiding this comment.
Self-review round two (claims, callers, operations)
- Base: 8679f04, head: 6585bbd
- Claims checked (PR body, commit message, issue premises):
- "Packaging metadata only; no code change": confirmed by the diff (1 file, 1 line).
- Issue premise "follows semantic versioning": not stated anywhere in the repository docs, and past minor releases carried behavior changes. Dropped from the PR body.
- Built metadata: the first build ran on the uncommitted working tree (version
...g8679f04a3.d20260930). Rebuilt from the committed tree (3.36.1.dev420+g6585bbde4); the wheelMETADATAand the sdistPKG-INFOeach contain exactly oneDevelopment Status :: 5 - Production/Stable;uvx twine checkpassed. PR body updated.
- Existing caller / documentation reader: no code, doc, or test reads or states the development status.
- AWS operator:
pyproject.tomlmatches the shared-path pattern at.github/workflows/test.yaml:125, so the AWS suites run (newest Python only) once the PR is Ready. Stated in the PR body. - Result: FINDINGS (claims only), corrected in the PR body; no code change.
| license-files = ["LICENSE", "NOTICE"] | ||
| classifiers = [ | ||
| "Development Status :: 4 - Beta", | ||
| "Development Status :: 5 - Production/Stable", |
Member
Author
There was a problem hiding this comment.
Independent review (relayed Codex result)
- Reviewer: Codex CLI 0.157.1, model gpt-6-sol, reasoning effort high,
codex exec --sandbox read-only; session 01a0f0e8-19ef-7ad1-abed-9585f79c273c. - Scope:
git diff 8679f04a36f6ffd7190b892c32b1938672ab502f..6585bbde4eae71bc268c0780e51a08ad3cb9301ain a detached snapshot at 6585bbd. The prompt omitted the PR number, PR text, commit message, and earlier findings. Review only: no edits, builds, tests, GitHub, or network. The snapshot and the PR worktree were verified unchanged afterwards. Static review only. - Covered (reviewer's list): the pinned diff, the Trove classifier spelling, Hatchling and license metadata, Python version classifiers, README and docs, repository references to development status, packaging checks, and CI and release workflows.
- Result: CLEAN. "I found no inconsistent status reference or related change required by this edit."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Change the
Development Statusclassifier inpyproject.tomlfrom4 - Betato5 - Production/Stable.Packaging metadata only; no code change.
WHY
Closes #865.
PyAthena has been used in production for years, and the 4.0.0 major release is the point to declare it stable.
TEST
Tested commit: 6585bbd
just lint: passed.uv buildfrom the committed tree (version3.36.1.dev420+g6585bbde4): the wheelMETADATAand the sdistPKG-INFOeach contain exactly oneDevelopment Statusclassifier,5 - Production/Stable.uvx twine checkon both artifacts: passed.pyproject.tomlis a shared path intest.yaml, so the AWS suites run in CI once the PR is Ready.🤖 Generated with Claude Code