Skip to content

Mark the package as Production/Stable - #904

Merged
laughingman7743 merged 1 commit into
masterfrom
chore/865-production-stable
Sep 30, 2026
Merged

laughingman7743 merged 1 commit into
masterfrom
chore/865-production-stable

Conversation

@laughingman7743

@laughingman7743 laughingman7743 commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

WHAT

Change the Development Status classifier in pyproject.toml from 4 - Beta to 5 - Production/Stable.

Packaging metadata only; no code change.

WHY

Closes #865.

PyAthena has been used in production for years, and the 4.0.0 major release is the point to declare it stable.

TEST

Tested commit: 6585bbd

  • just lint: passed.
  • uv build from the committed tree (version 3.36.1.dev420+g6585bbde4): the wheel METADATA and the sdist PKG-INFO each contain exactly one Development Status classifier, 5 - Production/Stable.
  • uvx twine check on both artifacts: passed.
  • No local AWS tests: metadata-only change. pyproject.toml is a shared path in test.yaml, so the AWS suites run in CI once the PR is Ready.
  • Not verifiable in this PR: PyPI showing the new status after the 4.0.0 release.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@laughingman7743 laughingman7743 added this to the 4.0.0 milestone Sep 30, 2026
Comment thread pyproject.toml
license-files = ["LICENSE", "NOTICE"]
classifiers = [
"Development Status :: 4 - Beta",
"Development Status :: 5 - Production/Stable",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review round one (implementation behavior)

  • Perspective: behavior/failure paths, resource boundaries, framework contracts, simplicity and test quality.
  • Base: 8679f04, head: 6585bbd
  • Covered: the one-line classifier change; git grep for other readers of classifiers or the development status. The only hits are .github/workflows/test.yaml:95 (Python version classifiers, unrelated) and benchmarks/pyproject.toml:14 (Private :: Do Not Upload, a separate project). No runtime code reads the classifiers.
  • Result: CLEAN, no repairs.

Comment thread pyproject.toml
license-files = ["LICENSE", "NOTICE"]
classifiers = [
"Development Status :: 4 - Beta",
"Development Status :: 5 - Production/Stable",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review round two (claims, callers, operations)

  • Base: 8679f04, head: 6585bbd
  • Claims checked (PR body, commit message, issue premises):
    • "Packaging metadata only; no code change": confirmed by the diff (1 file, 1 line).
    • Issue premise "follows semantic versioning": not stated anywhere in the repository docs, and past minor releases carried behavior changes. Dropped from the PR body.
    • Built metadata: the first build ran on the uncommitted working tree (version ...g8679f04a3.d20260930). Rebuilt from the committed tree (3.36.1.dev420+g6585bbde4); the wheel METADATA and the sdist PKG-INFO each contain exactly one Development Status :: 5 - Production/Stable; uvx twine check passed. PR body updated.
  • Existing caller / documentation reader: no code, doc, or test reads or states the development status.
  • AWS operator: pyproject.toml matches the shared-path pattern at .github/workflows/test.yaml:125, so the AWS suites run (newest Python only) once the PR is Ready. Stated in the PR body.
  • Result: FINDINGS (claims only), corrected in the PR body; no code change.

Comment thread pyproject.toml
license-files = ["LICENSE", "NOTICE"]
classifiers = [
"Development Status :: 4 - Beta",
"Development Status :: 5 - Production/Stable",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review (relayed Codex result)

  • Reviewer: Codex CLI 0.157.1, model gpt-6-sol, reasoning effort high, codex exec --sandbox read-only; session 01a0f0e8-19ef-7ad1-abed-9585f79c273c.
  • Scope: git diff 8679f04a36f6ffd7190b892c32b1938672ab502f..6585bbde4eae71bc268c0780e51a08ad3cb9301a in a detached snapshot at 6585bbd. The prompt omitted the PR number, PR text, commit message, and earlier findings. Review only: no edits, builds, tests, GitHub, or network. The snapshot and the PR worktree were verified unchanged afterwards. Static review only.
  • Covered (reviewer's list): the pinned diff, the Trove classifier spelling, Hatchling and license metadata, Python version classifiers, README and docs, repository references to development status, packaging checks, and CI and release workflows.
  • Result: CLEAN. "I found no inconsistent status reference or related change required by this edit."

@laughingman7743
laughingman7743 marked this pull request as ready for review September 30, 2026 06:05
@laughingman7743
laughingman7743 merged commit 681e556 into master Sep 30, 2026
13 checks passed
@laughingman7743
laughingman7743 deleted the chore/865-production-stable branch September 30, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark the package as Production/Stable in 4.0.0

1 participant