Repository navigation
Conversation
tuple_caster loaded each subcaster from a temporary item, but uses the subcasters later. A subcaster can refer to its item, so a sequence that creates items on access caused a use-after-free. Assisted-by: ClaudeCode:claude-fable-5-2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
tuple_caster::loadloaded each subcaster from a temporaryseq[Is], which released the item whenload_implreturned. The subcasters are used later, in the conversion operator. A subcaster can refer to its item (for example, the caster of apy::class_type holds a pointer into the instance). If the sequence creates its items on access and does not keep them, the conversion read a destroyed object.The caster now holds the items in a
std::array<object, size>member. Atupleorlistargument was not affected in normal use, because the container keeps its items alive.This is the same item-lifetime problem that #6276 fixes for
array_caster.The new test fails on master.
Suggested changelog entry:
std::pair/std::tuplecaster for sequences that create their items on access.