Repository navigation
Conversation
The element loops of `array_caster` asked the sequence for its length more than once: one time to size the storage, and again for the end of the iteration. A sequence that reports different lengths could cause out-of-bounds accesses (a write for `std::valarray`, a read for `std::array`). The loops now read the length one time and index up to it. Assisted-by: ClaudeCode:claude-fable-5-2
This keeps the order that the loops had when they iterated over the sequence. Assisted-by: ClaudeCode:claude-fable-5-2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
The element loops of
array_casterasked the sequence for its length more than one time: once to size the storage, and again for the end of the iteration. A sequence that reports different lengths could cause out-of-bounds accesses: a write forstd::valarray, a read forstd::array. A list that another thread resizes in a free-threaded build is one example.The loops now read the length one time and index up to it.
This is split out of the
array_casterrework for #5765, which it does not depend on.Suggested changelog entry:
std::arrayorstd::valarrayfrom a sequence whose length changes during the conversion.