Skip to content

Improve annotation handling when remove rotation - #5031

Closed
MorningK wants to merge 1 commit into
pymupdf:mainfrom
MorningK:main
Closed

Improve annotation handling when remove rotation#5031
MorningK wants to merge 1 commit into
pymupdf:mainfrom
MorningK:main

Conversation

@MorningK

Copy link
Copy Markdown

Bug Fixes

  • Improved annotation handling to properly filter and skip unsupported annotation types during rectangle updates.

This PR was created by qwen-chat coder for task
53ebd7df-9bdf-4c85-8d89-99b5c4045b14.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved annotation handling to properly filter and skip unsupported
annotation types during rectangle updates.

* **Chores**
* Updated SSL configuration for package downloads to enhance
accessibility in certain environments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: qwen.ai[bot] <qwenlm-intl@service.alibaba.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Co-authored-by: kui.chen <kui.chen@cohl.com>
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@MorningK

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@MorningK

Copy link
Copy Markdown
Author

recheck

@JorjMcKie

Copy link
Copy Markdown
Collaborator

Again, thanks for your submission, but we are implementing a more complete solution that also include annotations that do not support the set_rect() method.
So going to close this PR.

@JorjMcKie JorjMcKie closed this Jul 27, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants