Skip to content

Make SCIP result deterministic - #5665

Open
yangdanny97 wants to merge 2 commits into
pyrefly-org:mainfrom
yangdanny97:main
Open

yangdanny97 wants to merge 2 commits into
pyrefly-org:mainfrom
yangdanny97:main

Conversation

@yangdanny97

@yangdanny97 yangdanny97 commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

I realized the ordering of the SCIP documents is not deterministic when we dump the data. This PR adds a sorting pass at the end and also slightly tweaks the docs.

Storing these docs in memory increases peak memory by 150-200mb on pytorch

@stroxler stroxler self-assigned this Nov 16, 2026

@stroxler stroxler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Could you rebase? We had an outage in diff import handling, but that should be fixed now

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants