Repository navigation
Make SCIP result deterministic - #5665
Open
yangdanny97 wants to merge 2 commits into
Open
yangdanny97 wants to merge 2 commits into
yangdanny97 wants to merge 2 commits into
Conversation
stroxler
requested changes
Nov 17, 2026
stroxler
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
Could you rebase? We had an outage in diff import handling, but that should be fixed now
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized the ordering of the SCIP documents is not deterministic when we dump the data. This PR adds a sorting pass at the end and also slightly tweaks the docs.
Storing these docs in memory increases peak memory by 150-200mb on pytorch