Repository navigation
Conversation
ionelmc
force-pushed
the
fix/xdist-custom-coverage-data-file
branch
from
October 18, 2026 17:44
bf248c5 to
aa3b382
Compare
ionelmc
force-pushed
the
fix/xdist-custom-coverage-data-file
branch
from
October 18, 2026 21:49
aa3b382 to
9346856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When xdist workers run in non-collocated directories and coverage is configured with a custom
[run] data_file, the master deserializes worker data into the default.coveragebasename. Those worker files are then missed by the combiner, leaving the configured coverage database without the test lines.Use the combiner configured data filename as the
CoverageDatabasename when deserializing remote worker data. Extend the existing non-collocated regression across default and nested custom filenames, for both line and branch coverage. Add changelog and author credit.Verification
tox -e checkpassed with onlytaplo-lintskipped. Unskipped Taplo failed while decoding its online schema catalog; other hooks passed. The full tox matrix and Windows/PyPy runs were not performed locally.AI assistance was used to prepare the patch, regression tests, and validation. I reviewed and approved the code fix before submission.