Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a transactional test has both
@pytest.mark.django_dband the declareddjango_db_serialized_rollbackfixture, database setup currently uses only the marker'sserialized_rollbackvalue. With the default marker value, migrated data is not serialized for restoration even though the fixture enables serialized rollback at execution time. A later transactional test can therefore lose rows inserted by a data migration.This change makes collection-time database serialization consider either the marker or the declared rollback fixture, matching the existing execution-time behavior. It adds a regression using a real data migration and two successive transactional tests, plus controls for marker and fixture combinations. Dynamic fixture lookup is not changed.
Validation
git diff --check: passed.Tests were run with SQLite on macOS. PostgreSQL, MySQL, other platforms, and the full hosted matrix remain unverified locally.
AI assistance was used to prepare the implementation and regression tests.