Repository navigation
Document resetall, the changelog format and running tests with tox - #635
Merged
nicoddemus merged 1 commit intoOct 17, 2026
Merged
Conversation
* usage: add a "Resetting mocks" section describing what resetall() resets, its return_value/side_effect arguments, and how patch.multiple, patch.dict and spies are handled. * contributing: explain why tests should be run with tox, update the baseline environments, and describe the changelog entry format. * pre-commit: lint RELEASING.rst and the docs with the rst hook, which still referred to HOWTORELEASE.rst and a changelog/ directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation gaps that came up repeatedly while reviewing the recent PRs:
docs/usage.rst:mocker.resetall()was a one-line bullet. It now has a "Resetting mocks" section describing which mocks it resets (not stubs ormocker.Mock()), thereturn_value/side_effectarguments, and howpatch.multiple(Fix resetall for mocks created by patch.multiple #629),patch.dictand spies (Reset spy_return and spy_exception in resetall() #630, Keep spies calling through after resetall(side_effect=True) #633) are handled.docs/contributing.rst:tox: with the editable install, runningpytestdirectly doesn't rewrite the assertions insidepytest_mock, so the introspection tests fail regardless of the change.py314,norewrite..pre-commit-config.yaml: thersthook still referred toHOWTORELEASE.rstand achangelog/directory, soRELEASING.rstand the docs were never linted. It now covers them, exceptdocs/index.rst, which uses Sphinx-only directives.The new usage example passes as a test, and the docs build with
sphinx -W.🤖 Generated with Claude Code