Repository navigation
Register each patcher from mocker.patch.multiple individually - #648
Open
patrickswedish wants to merge 1 commit into
Open
patrickswedish wants to merge 1 commit into
patrickswedish wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638.
Summary
mocker.patch.multiple()previously registered the returned dictionary as a single entry in_mock_cache. As a result:PytestMockWarningcontext-manager hook was checked on the dictionary rather than on each patched mock.mocker.stop()could not stop an individual mock returned by (or passed to)mocker.patch.multiple().Changes
MockerFixture._Patcher.multiple(), splitpatcherandpatcher.additional_patchersinto individual single-attribute patchers (p.attribute_name = None,patcher.additional_patchers.clear()) and start each one throughself._start_patch(...).multiple(), stop and unregister the previously started patchers from that call before re-raising.MockCacheItem.reset_mocksindirection, since each patched value frompatch.multipleis now directly registered in_mock_cachelikepatchandpatch.object.TestStopandTestContextManagerWarnings.