Authenticate xdist StatusDB connections - #358
Merged
Merged
Conversation
janmrow
marked this pull request as ready for review
August 27, 2026 15:33
icemac
reviewed
Aug 28, 2026
icemac
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the handshake against the branch (suite also run under xdist: 175 passed). The change itself is sound — the token is assigned before run_server starts, the with conn, suppress(...) nesting order is right, failures_db is always a ServerStatusDB where .token is read, the token survives execnet serialization, and both new tests fail before the change and pass after.
Three things on the error paths, though; the first two chain into a session hang under xdist.
— Comment created by Claude
3 tasks
icemac
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate a per-session token on the xdist controller and pass it to workers through
workerinput.StatusDB now requires a successful handshake before processing commands and rejects clients with an invalid token.
Tests cover the authentication check and passing the connection details to workers.