fix(rewrite): short-circuit chained comparisons - #14822

Draft

RonnyPfannschmidt wants to merge 18 commits into

pytest-dev:mainfrom

RonnyPfannschmidt:ronny/fix-chained-compare-short-circuit

Commits on Aug 26, 2026

fix(rewrite): prevent walrus operator double evaluation in assertions

committed
792fa39
Add changelog fragment for #14445

committed
54bd8e9
test(rewrite): add xfail tests for remaining walrus edge cases

committed
32829dd
fix(rewrite): avoid double evaluation of walrus in BoolOp condition

committed
960a58c
fix(rewrite): assign walrus comparators to temps in chained comparisons

committed
298ca95
fix(rewrite): show correct walrus values in BoolOp explanations

committed
c90c70f
refactor(rewrite): minimal snapshots in BoolOp for walrus conflicts

committed
9f9e738
fix(rewrite): freeze operands a later walrus would clobber

RonnyPfannschmidt
and
claude
committed
72f4a7d
test(rewrite): retire the walrus tests the matrix subsumes

RonnyPfannschmidt
and
claude
committed
0253180
fix(rewrite): freeze walrus and starred operands too

RonnyPfannschmidt
and
claude
committed
5663cf5
refactor(rewrite): drop the walrus snapshot visit_Compare no longer needs

RonnyPfannschmidt
and
claude
committed
338cd67
refactor(rewrite): drop the unreachable Load guard in visit_Attribute

RonnyPfannschmidt
and
claude
committed
b45dc77
feat(rewrite): introspect container[key] in failure messages

RonnyPfannschmidt
and
claude
committed
b3d36ca
feat(rewrite): introspect the condition of a ternary

RonnyPfannschmidt
and
claude
committed
c812cee
feat(rewrite): show a method call on one line

RonnyPfannschmidt
and
claude
committed
3403e04
fix(rewrite): freeze operands against any later side effect (#14820)

RonnyPfannschmidt
and
claude
committed
fe23ee2
fix(rewrite): short-circuit chained comparisons (#14819)

RonnyPfannschmidt
and
claude
committed
d3d3151
fix(rewrite): guard a chained comparison's explanation too

RonnyPfannschmidt
and
claude
committed
02d56fa

Navigation Menu

Uh oh!

Uh oh!

fix(rewrite): short-circuit chained comparisons - #14822

fix(rewrite): short-circuit chained comparisons#14822
RonnyPfannschmidt wants to merge 18 commits into
pytest-dev:mainfrom
RonnyPfannschmidt:ronny/fix-chained-compare-short-circuit

Commits on Aug 26, 2026

fix(rewrite): prevent walrus operator double evaluation in assertions

Add changelog fragment for #14445

test(rewrite): add xfail tests for remaining walrus edge cases

fix(rewrite): avoid double evaluation of walrus in BoolOp condition

fix(rewrite): assign walrus comparators to temps in chained comparisons

fix(rewrite): show correct walrus values in BoolOp explanations

refactor(rewrite): minimal snapshots in BoolOp for walrus conflicts

fix(rewrite): freeze operands a later walrus would clobber

test(rewrite): retire the walrus tests the matrix subsumes

fix(rewrite): freeze walrus and starred operands too

refactor(rewrite): drop the walrus snapshot visit_Compare no longer needs

refactor(rewrite): drop the unreachable Load guard in visit_Attribute

feat(rewrite): introspect container[key] in failure messages

feat(rewrite): introspect the condition of a ternary

feat(rewrite): show a method call on one line

fix(rewrite): freeze operands against any later side effect (#14820)

fix(rewrite): short-circuit chained comparisons (#14819)

fix(rewrite): guard a chained comparison's explanation too