Fix #14902: disambiguate duplicate report headings - #14946
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14902.
When multiple tests share the same function name, their terminal error or failure sections currently receive identical headings. This makes it difficult to tell which traceback belongs to which test.
This change counts the headings in each summary and uses the test's cwd-relative node ID only when a heading is duplicated. Unique headings retain the existing concise output. Error phases are counted separately so setup and teardown reports remain naturally distinct.
Regression coverage verifies duplicate setup-error headings and duplicate failure headings across two test files.
Validation:
python -m pytest -q testing/test_terminal.py— 222 passed, 9 skippedpre-commit run --files AUTHORS changelog/14902.bugfix.rst src/_pytest/terminal.py testing/test_terminal.py --show-diff-on-failure— passedAI assistance: Codex assisted with reproducing the issue, implementing the change, and running validation. I reviewed the resulting behavior and test evidence and take responsibility for the contribution.