Repository navigation
Conversation
Session.collect disabled the collection cache for a file's parent Directory whenever the remaining match part was a single file path. That made N explicit file arguments from the same directory re-walk the directory N times (quadratic in directory size). Keep using the cache for Directory nodes unless --keep-duplicates is set; file-level non-dedup is already handled in genitems. Fixes pytest-dev#15187.
for more information, see https://pre-commit.ci
psf-chronographer
Bot
added
the
bot:chronographer:provided
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When several test files from the same directory are passed as separate command-line arguments,
Session.collectre-collected the parent directory once per argument, making collection cost O(files × directory entries).Use the collection cache for
Directorynodes in that branch (unless--keep-duplicatesis set). File-level non-deduplication for a path named twice remains handled ingenitems.Fixes #15187.
Test plan
pytest_collect_fileonce--keep-duplicateswith a repeated file still collects twice