Repository navigation
Handle Optional unions in the tagged union strategy - #828
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #345.
configure_tagged_union(Foo | Bar, converter)only registered hooks for the exact union, so a field typedFoo | Bar | Nonefell back to the default union handling: unstructuring dropped the_typetag, and structuring could not disambiguate (it even failed forNone).The strategy now also registers hooks for the union extended with
None. Those hooks passNonethrough untouched and delegate everything else to the tagged union hooks, so both spellings work (Union[Foo, Bar, None]andOptional[Union[Foo, Bar]]), including when adefaultmember is configured.Tests:
test_optional_unionandtest_optional_union_in_classtotests/strategies/test_tagged_unions.py, covering direct union use and both field spellings, in both directions, includingNone.tests/strategies/suite: 276 passed, 15 xfailed.ruff checkandruff format --checkon the changed files: pass.A changelog entry is included in
HISTORY.md, and the strategy docstring documents the new behavior.