Repository navigation
Use unique defaulted fields as a fallback disambiguation signal - #830
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #521.
Structuring a union of classes whose fields all have defaults failed while generating the disambiguation function:
create_default_dis_funconly pinned classes by unique fields without defaults, since a defaulted field may be absent from the payload. But a defaulted unique field is still a reliable signal whenever it is present, which is exactly the case that matters here: the unstructured form ofB()is{"b": ""}, containing the signal.The pinning loop (extracted unchanged into a helper) now runs a second time with the opposite default criterion, but only when the first pass leaves more than one class unpinned — that is, only in cases that previously raised
TypeError. Unions that disambiguate today produce exactly the same disambiguation functions as before. If the second pass still leaves more than one class unpinned, theTypeErroris raised as before, and a payload matching no signal raisesValueErrorinstead of silently picking a class.Verification
C(a_or_b=B())→ JSON →C).tests/test_disambiguators.py: disambiguation by defaulted unique fields, a chain where a defaulted field becomes unique only after another class is pinned, and a check that identically-shaped classes still raiseTypeError.tests/test_disambiguators.py(61 passed),tests/test_unions.py,tests/strategies/andtests/test_structure.py(292 passed, 15 xfailed).ruff checkandruff formatclean on the touched files.