Conversation
CheckSchedulingDetails already fetched calendar-user-address-set and threw the result away, so a server that serves the property but leaves it empty was graded exactly like one that populates it. Xandikos 0.4.7 (or perhaps rather, the test user that the test container is populated with?) serves it empty. RFC 6638 section 2.4.1 says that the URI of the principal resource should be used if the calendar user address is not well-defined. Measured against live Xandikos: 'unsupported'. Prompt: Please fix [this check] in a new branch xandikos-empty-cuas on the caldav-server-tester project [Some manual changes done during review process] Assisted-By: Claude Opus 5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckSchedulingDetailsalready fetchedcalendar-user-address-setand threwthe result away, so a server that serves the property but leaves it empty was
graded exactly like one that populates it. It now records the new
scheduling.calendar-user-address-set.populated, measured against liveXandikos 0.4.7:
unsupported.The feature itself is defined in the companion caldav PR, python-caldav/caldav#716 — the two
belong together and have to be released together.
CI will be red on this branch, and it cannot be made green here: the check
asserts every configured feature is one the installed caldav knows, and this
one exists only in that branch.
mainis already red for the same reason(
auth.www-authenticate.usable-scheme, run 35495452947).pyproject.tomlstill says
caldav>=3.3.1; there is no released version to pin yet.🤖 Generated with Claude Code